DL-Mirrors/kernel-tenderloin-3.0
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qup_i2c: Fix Klocwork errors in I2C driver

Browse Source 
Signed-off-by: Harini Jayaraman <harinij@codeaurora.org>
This commit is contained in:
Harini Jayaraman
2011-09-20 18:32:34 -06:00
committed by Bryan Huntsman
parent a4a3eaf44a
commit ee31ae9d8a
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
drivers/i2c/busses/i2c-qup.c
View File

@@ -995,14 +995,16 @@ qup_i2c_probe(struct platform_device *pdev)
"gsbi_qup_i2c_addr"); "gsbi_qup_i2c_addr");
if (!gsbi_mem) { if (!gsbi_mem) {
dev_err(&pdev->dev, "no gsbi mem resource?\n"); dev_err(&pdev->dev, "no gsbi mem resource?\n");
return -ENODEV; ret = -ENODEV;
goto err_res_failed;
} }
gsbi_io = request_mem_region(gsbi_mem->start, gsbi_io = request_mem_region(gsbi_mem->start,
resource_size(gsbi_mem), resource_size(gsbi_mem),
pdev->name); pdev->name);
if (!gsbi_io) { if (!gsbi_io) {
dev_err(&pdev->dev, "GSBI region already claimed\n"); dev_err(&pdev->dev, "GSBI region already claimed\n");
return -EBUSY; ret = -EBUSY;
goto err_res_failed;
} }
} }
@@ -1170,6 +1172,7 @@ err_config_failed:
err_clk_get_failed: err_clk_get_failed:
if (gsbi_mem) if (gsbi_mem)
release_mem_region(gsbi_mem->start, resource_size(gsbi_mem)); release_mem_region(gsbi_mem->start, resource_size(gsbi_mem));
err_res_failed:
release_mem_region(qup_mem->start, resource_size(qup_mem)); release_mem_region(qup_mem->start, resource_size(qup_mem));
return ret; return ret;
} }
@@ -1204,7 +1207,6 @@ qup_i2c_remove(struct platform_device *pdev)
pm_runtime_disable(&pdev->dev); pm_runtime_disable(&pdev->dev);
kfree(dev);
if (!(dev->pdata->use_gsbi_shared_mode)) { if (!(dev->pdata->use_gsbi_shared_mode)) {
gsbi_mem = platform_get_resource_byname(pdev, IORESOURCE_MEM, gsbi_mem = platform_get_resource_byname(pdev, IORESOURCE_MEM,
"gsbi_qup_i2c_addr"); "gsbi_qup_i2c_addr");
@@ -1213,6 +1215,7 @@ qup_i2c_remove(struct platform_device *pdev)
qup_mem = platform_get_resource_byname(pdev, IORESOURCE_MEM, qup_mem = platform_get_resource_byname(pdev, IORESOURCE_MEM,
"qup_phys_addr"); "qup_phys_addr");
release_mem_region(qup_mem->start, resource_size(qup_mem)); release_mem_region(qup_mem->start, resource_size(qup_mem));
kfree(dev);
return 0; return 0;
} }