checkpatch: remove 'static const char * const' check
While this check is valid in theory, it generates a plethora of false positives on ALSA drivers and ends up causing more trouble than it saves. Signed-off-by: Gregory Bean <gbean@codeaurora.org>
This commit is contained in:
committed by
Bryan Huntsman
parent
675b31fc19
commit
f1fdaffaa7
@@ -1959,12 +1959,6 @@ sub process {
|
|||||||
$herecurr);
|
$herecurr);
|
||||||
}
|
}
|
||||||
|
|
||||||
# check for static const char * arrays.
|
|
||||||
if ($line =~ /\bstatic\s+const\s+char\s*\*\s*(\w+)\s*\[\s*\]\s*=\s*/) {
|
|
||||||
WARN("static const char * array should probably be static const char * const\n" .
|
|
||||||
$herecurr);
|
|
||||||
}
|
|
||||||
|
|
||||||
# check for static char foo[] = "bar" declarations.
|
# check for static char foo[] = "bar" declarations.
|
||||||
if ($line =~ /\bstatic\s+char\s+(\w+)\s*\[\s*\]\s*=\s*"/) {
|
if ($line =~ /\bstatic\s+char\s+(\w+)\s*\[\s*\]\s*=\s*"/) {
|
||||||
WARN("static char array declaration should probably be static const char\n" .
|
WARN("static char array declaration should probably be static const char\n" .
|
||||||
|
|||||||
Reference in New Issue
Block a user