DL-Mirrors/kernel-tenderloin-3.0
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pdc202xx_old: ignore "FIFO empty" bit in test_irq() method

Browse Source 
The driver takes into account not only the interrupt status bit but
also "FIFO empty" bit in its test_irq() method. This actually is a
superfluous check since for the DMA commands calling the
dma_test_irq() method further in the interrupt handler makes sure FIFO
is emptied.

Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Sergei Shtylyov
2010-04-14 05:52:59 +00:00
committed by David S. Miller
parent 63e7cf9105
commit f693be4d8a
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/ide/pdc202xx_old.c
View File

@@ -93,13 +93,13 @@ static int pdc202xx_test_irq(ide_hwif_t *hwif)
* bit 7: error, bit 6: interrupting, * bit 7: error, bit 6: interrupting,
* bit 5: FIFO full, bit 4: FIFO empty * bit 5: FIFO full, bit 4: FIFO empty
*/ */
return ((sc1d & 0x50) == 0x50) ? 1 : 0; return (sc1d & 0x40) ? 1 : 0;
} else { } else {
/* /*
* bit 3: error, bit 2: interrupting, * bit 3: error, bit 2: interrupting,
* bit 1: FIFO full, bit 0: FIFO empty * bit 1: FIFO full, bit 0: FIFO empty
*/ */
return ((sc1d & 0x05) == 0x05) ? 1 : 0; return (sc1d & 0x04) ? 1 : 0;
} }
} }