Wang Chen dad9b335c6
netdevice: Fix promiscuity and allmulti overflow ...
Max of promiscuity and allmulti plus positive @inc can cause overflow.
Fox example: when allmulti=0xFFFFFFFF, any caller give dev_set_allmulti() a
positive @inc will cause allmulti be off.
This is not what we want, though it's rare case.
The fix is that only negative @inc will cause allmulti or promiscuity be off
and when any caller makes the counters touch the roof, we return error.
Change of v2:
Change void function dev_set_promiscuity/allmulti to return int.
So callers can get the overflow error.
Caller's fix will be done later.
Change of v3:
1. Since we return error to caller, we don't need to print KERN_ERROR,
KERN_WARNING is enough.
2. In dev_set_promiscuity(), if __dev_set_promiscuity() failed, we
return at once.
Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com >
Acked-by: Patrick McHardy <kaber@trash.net >
Signed-off-by: David S. Miller <davem@davemloft.net >
2008-06-18 01:48:28 -07:00
2008-05-18 20:49:41 +02:00
2008-06-06 11:29:10 -07:00
2008-06-09 15:56:39 -07:00
2008-05-21 14:08:38 -07:00
2008-06-09 15:55:45 -07:00
2008-05-21 14:08:38 -07:00
2008-05-21 14:08:38 -07:00
2008-05-24 09:56:10 -07:00
2008-06-02 15:27:10 -07:00
2008-06-09 15:53:37 -04:00
2008-06-11 21:00:38 -07:00
2008-05-20 14:14:15 -07:00
2008-05-14 23:24:09 -07:00
2008-05-14 23:24:09 -07:00
2008-05-16 17:23:05 -04:00
2008-05-13 08:02:25 -07:00
2008-06-06 11:29:10 -07:00
2008-05-28 14:49:27 +02:00
2008-05-29 01:38:46 -07:00
2008-05-31 16:36:16 -07:00
2008-06-11 19:13:45 -04:00
2008-05-13 08:02:25 -07:00
2008-05-29 21:10:01 -07:00
2008-05-16 17:22:26 -04:00
2008-06-06 11:29:11 -07:00
2008-05-13 08:02:26 -07:00
2008-05-14 10:37:57 -07:00
2008-05-24 09:56:13 -07:00
2008-05-10 20:58:02 -07:00
2008-05-20 16:44:43 +02:00
2008-05-20 16:44:43 +02:00
2008-05-18 20:49:41 +02:00
2008-06-10 20:56:36 +02:00
2008-06-14 12:18:12 -04:00
2008-06-11 21:00:38 -07:00
2008-06-11 21:00:38 -07:00
2008-06-11 21:00:38 -07:00
2008-06-16 16:48:20 -07:00
2008-06-03 16:36:01 -07:00
2008-06-03 16:37:33 -07:00
2008-05-16 17:22:20 -04:00
2008-05-30 10:40:46 -04:00
2008-06-11 19:13:46 -04:00
2008-06-11 21:00:38 -07:00
2008-06-10 12:39:35 -07:00
2008-06-06 17:50:40 -04:00
2008-05-15 17:50:37 -07:00
2008-05-20 17:23:03 -07:00
2008-05-14 19:11:14 -07:00
2008-06-06 21:25:51 +03:00
2008-06-04 06:40:41 -04:00
2008-06-12 10:47:58 +02:00
2008-06-09 11:32:41 +10:00
2008-05-13 08:02:25 -07:00
2008-06-12 18:05:41 -07:00
2008-05-24 09:56:09 -07:00
2008-05-24 09:56:13 -07:00
2008-05-26 16:08:40 +02:00
2008-06-08 11:58:43 -07:00
2008-06-06 11:29:12 -07:00
2008-06-12 08:40:37 +02:00
2008-06-18 01:48:28 -07:00
2008-06-09 15:57:24 -07:00
2008-06-09 15:58:05 -07:00
2008-05-21 14:08:38 -07:00
2008-06-05 11:23:39 -07:00
2008-06-14 12:18:01 -04:00
2008-06-17 23:59:41 -04:00
2008-06-09 10:22:24 -07:00
2008-05-14 19:23:25 -05:00
2008-06-13 20:52:39 -07:00
2008-05-14 19:11:14 -07:00
2008-06-11 21:00:38 -07:00
2008-06-11 21:00:38 -07:00
2008-06-12 18:05:40 -07:00
2008-06-10 15:44:49 -07:00
2008-06-10 11:37:25 +02:00
2008-06-03 08:20:17 -07:00
2008-06-06 11:29:14 -07:00
2008-05-24 09:56:12 -07:00
2008-06-11 21:58:11 -04:00
2008-06-17 16:19:24 -07:00
2008-06-13 20:52:39 -07:00
2008-06-12 10:48:00 +02:00
2008-05-21 14:52:30 -07:00
2008-05-29 14:46:30 +02:00
2008-06-06 11:29:10 -07:00
2008-05-24 09:56:09 -07:00
2008-06-16 17:14:11 -07:00
2008-06-05 06:35:47 -03:00
2008-05-30 15:09:45 +10:00
2008-05-30 15:09:46 +10:00
2008-06-10 18:20:30 -04:00
2008-05-30 15:09:44 +10:00
2008-05-29 01:43:48 -07:00
2008-06-03 15:00:28 -04:00
2008-05-27 01:37:26 -04:00
dad9b335c6