Bartlomiej Zolnierkiewicz 3ab7efe8e2
ide: DMA reporting and validity checking fixes (take 3) ...
* ide_xfer_verbose() fixups:
- beautify returned mode names
- fix PIO5 reporting
- make it return 'const char *'
* Change printk() level from KERN_DEBUG to KERN_INFO in ide_find_dma_mode().
* Add ide_id_dma_bug() helper based on ide_dma_verbose() to check for invalid
DMA info in identify block.
* Use ide_id_dma_bug() in ide_tune_dma() and ide_driveid_update().
As a result DMA won't be tuned or will be disabled after tuning if device
reports inconsistent info about enabled DMA mode (ide_dma_verbose() does the
same checks while the IDE device is probed by ide-{cd,disk} device driver).
* Remove no longer needed ide_dma_verbose().
This patch should fix the following problem with out-of-sync IDE messages
reported by Nick Warne:
hdd: ATAPI 48X DVD-ROM DVD-R-RAM CD-R/RW drive, 2048kB Cache<7>hdd:
skipping word 93 validity check
, UDMA(66)
and later debugged by Mark Lord to be caused by:
ide_dma_verbose()
printk( ... "2048kB Cache");
eighty_ninty_three()
printk(KERN_DEBUG "%s: skipping word 93 validity check\n");
ide_dma_verbose()
printk(", UDMA(66)"
Please note that as a result ide-{cd,disk} device drivers won't report the
DMA speed used but this is intended since now DMA mode being used is always
reported by IDE core code.
v2:
* fixes suggested by Randy:
- use KERN_CONT for printk()-s in ide-{cd,disk}.c
- don't remove argument name from ide_xfer_verbose() declaration
v3:
* Remove incorrect check for (id->field_valid & 1) from ide_id_dma_bug()
(spotted by Sergei).
* "XFER SLOW" -> "PIO SLOW" in ide_xfer_verbose() (suggested by Sergei).
* Fix ide_find_dma_mode() to report the correct mode ('mode' after being
limited by 'req_mode').
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com >
Cc: Nick Warne <nick@ukfsn.org >
Cc: Mark Lord <lkml@rtr.ca >
Cc: Randy Dunlap <randy.dunlap@oracle.com >
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com >
2007-12-12 23:31:58 +01:00
2007-10-14 20:17:39 -07:00
2007-10-17 22:51:13 +02:00
2007-10-13 14:36:18 +01:00
2007-11-07 04:08:21 -08:00
2007-10-15 12:26:29 -07:00
2007-10-15 12:26:29 -07:00
2007-11-07 04:08:21 -08:00
2007-11-07 04:08:21 -08:00
2007-10-16 09:43:10 -07:00
2007-10-17 08:43:03 -07:00
2007-10-16 10:13:38 -07:00
2007-11-26 16:24:50 -05:00
2007-10-15 17:56:36 -07:00
2007-11-20 01:16:29 -05:00
2007-10-14 12:41:51 -07:00
2007-10-18 14:37:20 -07:00
2007-10-23 15:49:47 +10:00
2007-11-05 18:10:28 -05:00
2007-10-17 08:42:47 -07:00
2007-10-21 02:37:45 -04:00
2007-10-17 08:43:00 -07:00
2007-10-17 08:42:45 -07:00
2007-10-17 08:43:07 -07:00
2007-10-16 11:03:56 +02:00
2007-10-18 14:37:29 -07:00
2007-10-19 11:53:42 -07:00
2007-10-19 11:53:42 -07:00
2007-11-09 13:41:32 +01:00
2007-10-29 14:05:37 -07:00
2007-10-16 09:42:58 -07:00
2007-10-22 08:13:18 -07:00
2007-10-20 03:10:57 +02:00
2007-12-02 20:04:49 +01:00
2007-10-19 11:53:36 -07:00
2007-10-19 11:53:36 -07:00
2007-10-14 22:57:45 +02:00
2007-10-18 14:37:20 -07:00
2007-10-17 08:42:47 -07:00
2007-10-17 08:42:47 -07:00
2007-10-18 14:37:32 -07:00
2007-10-17 08:42:47 -07:00
2007-10-25 15:10:17 -07:00
2007-10-24 18:23:48 +02:00
2007-10-16 09:43:13 -07:00
2007-10-16 09:43:20 -07:00
2007-10-18 14:37:19 -07:00
2007-10-17 08:42:52 -07:00
2007-10-18 14:37:28 -07:00
2007-11-19 21:43:22 -05:00
2007-10-19 11:53:44 -07:00
2007-10-17 08:42:53 -07:00
2007-10-19 23:07:36 +02:00
2007-10-18 14:37:26 -07:00
2007-10-16 09:43:09 -07:00
2007-10-21 02:37:45 -04:00
2007-10-24 10:27:48 -02:00
2007-10-19 11:53:36 -07:00
2007-11-02 08:47:25 +01:00
2007-10-31 12:51:29 -07:00
2007-10-20 02:00:58 +01:00
2007-10-18 14:37:21 -07:00
2007-10-22 08:13:19 -07:00
2007-10-23 15:49:47 +10:00
2007-10-22 08:13:19 -07:00
2007-10-22 08:13:20 -07:00
2007-10-17 08:43:00 -07:00
2007-10-17 08:42:51 -07:00
2007-10-29 07:41:32 -07:00
2007-10-22 08:13:21 -07:00
2007-10-17 08:43:02 -07:00
2007-11-29 09:24:53 -08:00
2007-10-17 08:42:48 -07:00
2007-11-14 18:45:43 -08:00
2007-10-17 18:50:03 -04:00
2007-10-17 18:49:59 -04:00
2007-10-17 18:49:59 -04:00
2007-10-17 18:50:02 -04:00
2007-10-17 18:49:58 -04:00
2007-11-08 08:42:46 -05:00
2007-10-16 09:43:22 -07:00
2007-10-17 08:43:01 -07:00
2007-10-17 08:43:04 -07:00
2007-10-17 21:21:26 -07:00
2007-10-17 00:00:08 +02:00
2007-10-18 14:37:19 -07:00
2007-10-22 08:13:21 -07:00
2007-10-21 02:37:18 -04:00
2007-11-29 09:24:54 -08:00
2007-11-05 21:53:46 +11:00
2007-10-16 09:43:00 -07:00
2007-10-14 12:41:51 -07:00
2007-10-19 11:53:42 -07:00
2007-10-15 08:12:00 -07:00
2007-10-18 22:54:18 +02:00
2007-11-14 18:45:40 -08:00
2007-10-13 23:56:32 +02:00
2007-10-16 15:58:19 +02:00
2007-11-15 19:24:02 +01:00
2007-10-16 11:21:00 +02:00
2007-10-22 00:56:52 -04:00
2007-12-12 23:31:58 +01:00
2007-12-07 15:00:32 -05:00
2007-10-15 12:26:29 -07:00
2007-10-17 08:42:52 -07:00
2007-12-05 05:37:32 -08:00
2007-10-19 11:53:43 -07:00
2007-10-17 08:42:56 -07:00
2007-10-21 02:37:38 -04:00
2007-11-27 00:47:04 -05:00
2007-10-17 08:43:00 -07:00
2007-10-16 09:43:01 -07:00
2007-10-19 11:53:48 -07:00
2007-10-30 08:06:55 -07:00
2007-10-18 14:37:32 -07:00
2007-10-16 09:43:10 -07:00
2007-10-17 18:49:58 -04:00
2007-12-05 09:21:20 -08:00
2007-10-16 09:42:49 -07:00
2007-11-05 15:12:32 -08:00
2007-10-17 08:42:52 -07:00
2007-10-30 21:44:00 -07:00
2007-11-29 09:24:52 -08:00
2007-10-18 14:37:28 -07:00
2007-10-17 08:43:01 -07:00
2007-10-19 11:53:49 -07:00
2007-10-17 08:42:57 -07:00
2007-10-17 08:42:57 -07:00
2007-10-19 11:53:33 -07:00
2007-10-12 14:51:12 -07:00
2007-10-16 09:43:10 -07:00
2007-10-13 10:18:29 +02:00
2007-12-07 09:06:53 +00:00
2007-10-25 15:02:50 +10:00
2007-10-25 15:02:50 +10:00
2007-11-19 12:28:11 +09:00
2007-10-22 08:13:17 -07:00
2007-10-19 11:53:35 -07:00
2007-10-19 11:53:38 -07:00
2007-10-17 08:42:56 -07:00
2007-10-19 11:53:36 -07:00
2007-10-19 11:53:55 -07:00
2007-11-14 18:45:41 -08:00
2007-10-16 09:43:02 -07:00
2007-10-22 08:13:17 -07:00
2007-10-19 11:53:36 -07:00
2007-10-17 08:43:00 -07:00
2007-12-06 00:25:10 +11:00
2007-10-17 08:42:46 -07:00
2007-10-23 15:49:54 +10:00
2007-10-19 11:53:54 -07:00
2007-10-17 08:42:56 -07:00
2007-11-07 04:08:55 -08:00
2007-10-19 11:53:44 -07:00
2007-10-17 08:42:57 -07:00
2007-10-30 14:32:16 -04:00
2007-10-23 08:23:00 -07:00
2007-10-17 08:42:44 -07:00
2007-10-17 08:42:55 -07:00
2007-11-12 18:10:39 -08:00
2007-11-01 02:21:47 -07:00
2007-10-15 12:26:29 -07:00
2007-10-15 12:26:29 -07:00
2007-11-07 04:15:12 -08:00
2007-11-26 16:24:48 -05:00
2007-10-17 08:42:58 -07:00
2007-10-16 09:42:58 -07:00
2007-10-19 11:53:34 -07:00
2007-10-19 11:53:37 -07:00
2007-10-17 22:30:07 +10:00
2007-10-17 21:17:42 -07:00
2007-10-19 11:53:41 -07:00
2007-10-17 08:42:46 -07:00
2007-10-16 09:43:02 -07:00
2007-10-16 09:43:02 -07:00
2007-10-16 09:42:55 -07:00
2007-10-23 19:53:16 -04:00
2007-11-23 20:54:01 -05:00
2007-10-12 15:03:18 -07:00
2007-11-05 13:35:17 -08:00
2007-10-17 08:42:44 -07:00
2007-10-19 11:53:41 -07:00
2007-12-04 15:06:33 -05:00
2007-11-14 18:45:43 -08:00
2007-10-19 11:53:41 -07:00
2007-10-18 14:37:18 -07:00
2007-11-29 09:24:52 -08:00
2007-10-17 18:49:58 -04:00
2007-10-19 20:35:04 +02:00
2007-10-19 11:53:41 -07:00
2007-12-05 09:21:20 -08:00
2007-10-17 08:42:55 -07:00
2007-10-17 08:42:45 -07:00
2007-10-17 08:42:56 -07:00
2007-10-16 09:42:53 -07:00
2007-10-17 08:42:46 -07:00
2007-10-19 11:53:35 -07:00
2007-10-22 08:13:20 -07:00
2007-11-29 09:24:54 -08:00
2007-11-12 17:58:35 -08:00
2007-11-27 09:30:39 +01:00
2007-11-28 15:52:56 +01:00
2007-11-29 09:24:54 -08:00
2007-10-14 12:41:51 -07:00
2007-10-20 00:53:30 +02:00
2007-10-16 09:43:17 -07:00
2007-11-17 10:38:16 +11:00
2007-10-19 11:53:44 -07:00
2007-10-17 08:42:53 -07:00
2007-11-29 09:24:53 -08:00
2007-10-19 11:53:44 -07:00
2007-10-17 08:43:01 -07:00
2007-11-26 23:11:19 +08:00
2007-10-17 08:42:45 -07:00
2007-10-17 08:42:45 -07:00
2007-10-16 09:43:14 -07:00
2007-11-09 22:39:38 +01:00
2007-10-22 02:59:48 -07:00
2007-10-14 12:41:51 -07:00
2007-10-30 21:44:00 -07:00
2007-10-18 14:37:20 -07:00
2007-10-17 08:42:45 -07:00
2007-11-20 11:13:45 +01:00
2007-10-12 14:51:12 -07:00
2007-10-18 14:37:28 -07:00
2007-10-15 12:59:43 -07:00
2007-12-05 15:46:09 +01:00
2007-10-17 08:42:53 -07:00
2007-11-26 20:42:19 +01:00
2007-10-15 17:00:19 +02:00
2007-11-07 04:14:19 -08:00
2007-10-29 07:41:33 -07:00
2007-10-17 08:42:51 -07:00
2007-10-19 11:53:42 -07:00
2007-11-28 13:58:35 -08:00
2007-11-28 13:58:34 -08:00
2007-10-22 12:01:30 -02:00
2007-10-22 12:01:24 -02:00
2007-10-23 13:47:31 -05:00
2007-10-23 15:49:54 +10:00
2007-10-23 15:49:54 +10:00
2007-10-23 15:49:55 +10:00
2007-10-23 15:49:54 +10:00
2007-11-12 13:59:40 +11:00
2007-10-23 15:49:54 +10:00
2007-10-17 08:42:56 -07:00
2007-10-19 11:53:34 -07:00
2007-10-19 11:53:38 -07:00
2007-10-17 08:43:02 -07:00
3ab7efe8e2