Files
kernel-tenderloin-3.0/include/linux
Stanislaw Gruszka 673e63c688 net: fix ethtool->set_flags not intended -EINVAL return value
After commit d5dbda2380 "ethtool: Add
support for vlan accleration.", drivers that have NETIF_F_HW_VLAN_TX,
and/or NETIF_F_HW_VLAN_RX feature, but do not allow enable/disable vlan
acceleration via ethtool set_flags, always return -EINVAL from that
function. Fix by returning -EINVAL only if requested features do not
match current settings and can not be changed by driver.

Change any driver that define ethtool->set_flags to use
ethtool_invalid_flags() to avoid similar problems in the future
(also on drivers that do not have the problem).

Tested with modified (to reproduce this bug) myri10ge driver.

Cc: stable@kernel.org # 2.6.37+
Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2011-03-27 23:35:24 -07:00
..
2011-03-27 23:34:59 -07:00
2011-03-04 12:24:31 -08:00
2011-01-20 18:30:17 -08:00
2011-01-20 18:30:17 -08:00
2011-01-31 14:03:00 -08:00
2011-01-15 20:07:45 -05:00
2011-01-13 08:03:12 -08:00
2011-02-16 13:30:48 +01:00
2011-02-16 13:30:48 +01:00
2011-01-10 08:51:44 -08:00
2011-02-03 15:39:16 -08:00
2011-01-12 20:16:43 -05:00
2011-03-14 19:12:20 -04:00
2011-01-10 08:51:44 -08:00
2011-01-07 17:50:27 +11:00
2011-03-17 21:31:32 -04:00
2011-01-07 17:50:23 +11:00
2011-03-04 17:53:39 -08:00
2011-03-05 10:56:00 +01:00
2011-02-23 00:53:26 +00:00
2011-02-27 16:11:51 -08:00
2011-03-11 14:15:35 +01:00
2011-01-31 14:03:00 -08:00
2011-02-17 11:12:40 -08:00
2011-01-13 17:32:31 -08:00
2011-02-01 08:23:22 +10:00
2011-01-13 17:32:47 -08:00
2011-02-13 16:54:24 -08:00
2011-01-24 14:45:11 +10:30
2011-01-14 13:12:45 +00:00
2011-03-16 09:58:31 -07:00
2011-01-13 17:32:41 -08:00
2011-01-13 17:32:46 -08:00
2011-02-15 10:24:31 +01:00
2011-01-16 13:47:07 -05:00
2011-03-11 15:38:44 -05:00
2011-03-14 18:25:53 -04:00
2011-01-13 17:32:43 -08:00
2011-01-16 13:47:07 -05:00
2011-03-11 15:13:26 -05:00
2011-03-15 00:43:16 +01:00
2011-01-13 08:03:21 -08:00
2011-01-14 02:36:43 +00:00
2011-01-13 08:03:18 -08:00
2011-01-13 17:32:42 -08:00
2011-01-07 17:50:27 +11:00
2011-01-13 08:03:19 -08:00
2011-01-13 17:32:42 -08:00
2011-02-28 18:00:31 -08:00
2011-02-21 12:53:08 -08:00
2011-02-02 15:28:18 +01:00
2011-01-24 14:45:11 +10:30
2011-01-13 08:03:24 -08:00