Miklos Szeredi 8039a47e67
fix shrink_dcache_parent() livelock ...
commit eaf5f9073533cde21c7121c136f1c3f072d9cf59 upstream.
Two (or more) concurrent calls of shrink_dcache_parent() on the same dentry may
cause shrink_dcache_parent() to loop forever.
Here's what appears to happen:
1 - CPU0: select_parent(P) finds C and puts it on dispose list, returns 1
2 - CPU1: select_parent(P) locks P->d_lock
3 - CPU0: shrink_dentry_list() locks C->d_lock
dentry_kill(C) tries to lock P->d_lock but fails, unlocks C->d_lock
4 - CPU1: select_parent(P) locks C->d_lock,
moves C from dispose list being processed on CPU0 to the new
dispose list, returns 1
5 - CPU0: shrink_dentry_list() finds dispose list empty, returns
6 - Goto 2 with CPU0 and CPU1 switched
Basically select_parent() steals the dentry from shrink_dentry_list() and thinks
it found a new one, causing shrink_dentry_list() to think it's making progress
and loop over and over.
One way to trigger this is to make udev calls stat() on the sysfs file while it
is going away.
Having a file in /lib/udev/rules.d/ with only this one rule seems to the trick:
ATTR{vendor}=="0x8086", ATTR{device}=="0x10ca", ENV{PCI_SLOT_NAME}="%k", ENV{MATCHADDR}="$attr{address}", RUN+="/bin/true"
Then execute the following loop:
while true; do
echo -bond0 > /sys/class/net/bonding_masters
echo +bond0 > /sys/class/net/bonding_masters
echo -bond1 > /sys/class/net/bonding_masters
echo +bond1 > /sys/class/net/bonding_masters
done
One fix would be to check all callers and prevent concurrent calls to
shrink_dcache_parent(). But I think a better solution is to stop the
stealing behavior.
This patch adds a new dentry flag that is set when the dentry is added to the
dispose list. The flag is cleared in dentry_lru_del() in case the dentry gets a
new reference just before being pruned.
If the dentry has this flag, select_parent() will skip it and let
shrink_dentry_list() retry pruning it. With select_parent() skipping those
dentries there will not be the appearance of progress (new dentries found) when
there is none, hence shrink_dcache_parent() will not loop forever.
Set the flag is also set in prune_dcache_sb() for consistency as suggested by
Linus.
Signed-off-by: Miklos Szeredi <mszeredi@suse.cz >
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk >
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de >
2012-01-25 17:24:51 -08:00
2011-06-16 12:01:57 -07:00
2011-05-11 14:50:41 -04:00
2011-05-04 14:08:36 -07:00
2011-05-24 11:52:05 -07:00
2011-05-20 18:51:09 -03:00
2012-01-06 14:14:11 -08:00
2011-06-20 08:59:46 -07:00
2011-10-03 11:40:26 -07:00
2011-07-13 14:54:37 -04:00
2011-06-01 11:36:49 +01:00
2011-06-06 01:35:10 +02:00
2011-04-20 17:48:49 +04:00
2011-05-27 10:34:37 +01:00
2011-05-26 12:13:22 -07:00
2011-05-20 13:43:21 -07:00
2012-01-25 17:24:48 -08:00
2012-01-12 11:35:33 -08:00
2011-04-28 13:39:17 -07:00
2011-04-25 14:50:08 -04:00
2011-05-28 17:41:46 +02:00
2011-06-10 08:46:26 -06:00
2011-04-25 18:10:58 -07:00
2011-05-25 08:39:45 -07:00
2011-05-26 17:12:38 -07:00
2011-06-20 13:23:14 +02:00
2012-01-06 14:13:48 -08:00
2011-06-13 10:42:49 +02:00
2011-05-25 08:39:30 -07:00
2011-05-19 16:55:27 +09:30
2011-05-26 07:26:45 -04:00
2011-05-25 08:39:43 -07:00
2011-05-24 22:55:24 +10:00
2011-05-26 17:12:34 -07:00
2011-05-26 17:12:34 -07:00
2011-05-26 10:01:36 -06:00
2011-05-19 14:24:16 +02:00
2011-06-16 19:30:53 +02:00
2011-06-27 18:00:13 -07:00
2011-05-25 08:39:47 -07:00
2011-05-25 08:39:46 -07:00
2011-06-07 12:02:00 -07:00
2011-05-04 11:50:57 -04:00
2011-05-25 08:39:45 -07:00
2011-05-28 17:02:57 +02:00
2011-05-26 17:12:37 -07:00
2011-05-19 15:59:38 -07:00
2011-08-15 18:31:35 -07:00
2012-01-25 17:24:51 -08:00
2011-06-20 10:46:04 -04:00
2011-05-29 12:52:55 +01:00
2011-06-27 16:06:19 -07:00
2011-05-23 10:47:06 -05:00
2011-05-29 13:03:09 +01:00
2011-05-29 13:03:13 +01:00
2011-06-01 12:26:35 +01:00
2011-06-30 09:23:45 +02:00
2011-05-24 10:21:29 +02:00
2011-05-24 10:21:29 +02:00
2011-05-25 18:30:37 +05:30
2011-05-25 17:03:53 -07:00
2011-05-14 21:36:55 +01:00
2011-06-09 15:05:48 -07:00
2011-11-11 09:36:32 -08:00
2011-11-11 09:36:32 -08:00
2011-05-12 07:37:51 -07:00
2011-05-22 21:01:22 -04:00
2011-08-04 21:58:34 -07:00
2011-05-10 22:53:46 +02:00
2011-05-26 17:12:33 -07:00
2011-12-21 12:57:36 -08:00
2011-05-25 08:39:44 -07:00
2011-07-07 13:21:56 -07:00
2011-05-02 16:59:38 -07:00
2011-06-24 17:08:49 +09:00
2011-05-25 22:13:44 -04:00
2011-10-16 14:14:55 -07:00
2011-05-25 08:39:54 -07:00
2011-05-30 07:42:51 +02:00
2011-05-25 08:39:11 -07:00
2011-04-11 23:53:19 -07:00
2011-06-16 08:40:52 -06:00
2011-06-27 16:06:19 -07:00
2011-05-25 08:39:19 -07:00
2011-05-26 09:20:31 -07:00
2011-05-26 12:03:50 -07:00
2011-05-25 20:43:32 +02:00
2011-05-08 16:41:45 -07:00
2011-06-01 14:34:01 -04:00
2011-05-27 13:40:54 -04:00
2011-05-10 14:36:03 -07:00
2011-06-06 22:42:06 -07:00
2011-06-11 16:15:50 -07:00
2011-08-15 18:31:38 -07:00
2011-05-26 17:12:34 -07:00
2011-05-16 14:46:30 -04:00
2011-04-18 13:29:03 -07:00
2011-11-11 09:35:54 -08:00
2011-11-11 09:36:00 -08:00
2011-05-26 17:12:37 -07:00
2011-07-07 16:02:26 +00:00
2011-05-18 14:59:08 +02:00
2011-06-03 14:53:15 +02:00
2011-06-13 15:38:22 -04:00
2011-11-11 09:35:52 -08:00
2011-05-25 16:55:55 -07:00
2011-06-15 20:04:00 -07:00
2011-05-27 10:25:02 -07:00
2011-06-17 09:40:48 -07:00
2011-06-15 20:03:59 -07:00
2011-06-12 17:45:41 -04:00
2011-05-23 15:39:34 -07:00
2011-05-22 08:47:53 -04:00
2011-05-25 08:39:50 -07:00
2011-04-13 11:11:43 +02:00
2011-05-25 08:39:51 -07:00
2012-01-06 14:13:55 -08:00
2011-05-19 20:50:53 -04:00
2011-05-24 14:33:35 +02:00
2011-04-25 18:14:10 -07:00
2011-05-19 14:15:29 -07:00
2011-05-25 08:39:17 -07:00
2011-12-21 12:57:38 -08:00
2011-05-24 10:01:37 +02:00
2011-04-25 18:14:07 -04:00
2011-05-25 08:39:48 -07:00
2012-01-25 17:24:43 -08:00
2011-07-12 11:08:01 +10:00
2011-05-25 08:39:34 -07:00
2011-11-11 09:36:29 -08:00
2011-11-11 09:36:48 -08:00
2011-05-25 08:39:19 -07:00
2011-06-27 14:13:09 -07:00
2011-05-10 15:54:54 -04:00
2011-05-19 16:55:27 +09:30
2011-05-19 16:55:25 +09:30
2011-05-04 12:18:54 -07:00
2011-05-25 08:39:17 -07:00
2011-05-09 11:40:38 +10:00
2011-11-11 09:36:23 -08:00
2011-05-27 13:41:33 -04:00
2011-08-04 21:58:31 -07:00
2011-05-27 13:40:58 -04:00
2011-05-20 11:46:11 -07:00
2011-05-29 14:10:13 -07:00
2011-04-24 14:28:18 -04:00
2011-11-26 09:09:59 -08:00
2011-06-20 16:12:26 -04:00
2011-11-26 09:09:59 -08:00
2011-05-10 22:21:45 +09:00
2011-05-16 19:32:19 -04:00
2011-05-23 11:58:59 +02:00
2011-05-22 21:01:19 -04:00
2011-05-26 17:12:34 -07:00
2011-05-18 12:32:23 -06:00
2011-04-20 17:01:19 +10:00
2011-05-25 08:39:10 -07:00
2011-05-29 12:40:51 +02:00
2011-05-25 08:39:25 -07:00
2011-06-18 22:18:18 -04:00
2012-01-25 17:24:38 -08:00
2011-05-21 12:16:44 -07:00
2011-05-24 12:06:40 -07:00
2011-05-25 08:39:54 -07:00
2011-06-03 19:33:49 +03:00
2011-06-04 12:31:14 +02:00
2011-08-29 13:29:16 -07:00
2011-11-11 09:35:52 -08:00
2011-05-26 17:12:37 -07:00
2011-04-11 13:44:25 -07:00
2011-05-16 20:17:47 +02:00
2011-05-29 00:50:59 -04:00
2011-04-30 00:25:44 +02:00
2011-06-21 23:20:20 +02:00
2011-05-29 20:52:36 +03:00
2011-05-10 10:16:21 +02:00
2011-05-24 12:10:51 +02:00
2011-05-25 08:39:48 -07:00
2011-05-26 17:12:36 -07:00
2011-05-16 11:05:00 -07:00
2011-05-13 16:31:00 -07:00
2011-10-16 14:14:53 -07:00
2011-05-23 13:01:00 -07:00
2011-05-23 13:01:00 -07:00
2011-04-25 17:28:24 +02:00
2011-08-15 18:31:35 -07:00
2011-05-26 15:00:31 -04:00
2011-04-26 14:01:42 -07:00
2011-05-19 14:15:29 -07:00
2011-05-05 23:16:59 -07:00
2011-05-05 23:16:59 -07:00
2011-05-05 23:16:59 -07:00
2011-05-19 13:53:54 -04:00
2011-04-19 15:38:02 -04:00
2011-04-14 16:06:56 -07:00
2011-10-03 11:39:46 -07:00
2011-04-14 16:06:56 -07:00
2011-05-25 08:39:19 -07:00
2011-05-12 08:28:47 -07:00
2011-10-03 11:40:08 -07:00
2011-10-16 14:14:51 -07:00
2011-07-18 11:06:03 -07:00
2011-04-25 10:20:32 -04:00
2011-06-11 13:17:28 -07:00
2011-05-19 16:51:01 -07:00
2011-05-19 16:51:02 -07:00
2011-06-27 18:00:12 -07:00
2011-05-19 08:19:36 -07:00
2011-12-09 08:52:39 -08:00
2011-05-20 13:33:21 -07:00
2011-11-11 09:35:52 -08:00
2011-05-21 12:53:53 +03:00
2011-06-17 10:17:12 +02:00
2011-04-13 17:13:00 -07:00
2011-05-05 11:10:14 -07:00
2011-05-20 12:51:07 -07:00
2011-05-03 16:09:40 -07:00
2011-08-29 13:29:08 -07:00
2011-05-19 16:55:28 +09:30
2011-04-11 22:54:42 +02:00
2011-06-27 18:00:12 -07:00
2011-06-06 15:41:16 -04:00
2011-05-25 18:10:16 -07:00
2011-05-11 21:37:15 +02:00
2011-06-12 17:45:41 -04:00
2011-05-23 13:59:54 +02:00
2011-04-22 17:01:09 -07:00
2011-05-23 13:59:53 +02:00
2011-05-23 13:59:53 +02:00
2011-04-26 14:01:42 -07:00
2011-05-10 16:03:56 -04:00
2011-06-15 20:03:59 -07:00
2011-05-20 13:33:21 -07:00
2011-10-03 11:39:49 -07:00
2011-06-04 06:33:24 +09:00
2011-11-11 09:35:12 -08:00
2011-05-25 19:56:23 -04:00
2011-06-07 09:05:42 -07:00
2012-01-12 11:35:25 -08:00
2011-06-15 20:04:00 -07:00
2011-05-20 09:30:46 -03:00
2011-05-20 11:28:49 -03:00
2012-01-25 17:24:46 -08:00
2011-05-30 11:14:14 +09:30
2011-05-30 11:14:14 +09:30
2011-05-30 11:14:14 +09:30
2011-05-30 11:14:14 +09:30
2011-05-30 11:14:14 +09:30
2011-05-30 11:14:14 +09:30
2011-05-30 11:14:14 +09:30
2011-05-30 11:14:14 +09:30
2011-05-30 11:14:14 +09:30
2011-05-30 11:14:16 +09:30
2011-05-26 17:12:34 -07:00
2011-11-11 09:36:18 -08:00
2011-05-26 17:12:34 -07:00
2011-04-19 16:49:20 +03:00
2011-10-03 11:40:43 -07:00
2011-05-25 08:39:45 -07:00
8039a47e67