Files
kernel-tenderloin-3.0/include/linux
Jan Kara d4beaf4ab5 jbd: Fix assertion failure in fs/jbd/checkpoint.c
Before we start committing a transaction, we call
__journal_clean_checkpoint_list() to cleanup transaction's written-back
buffers.

If this call happens to remove all of them (and there were already some
buffers), __journal_remove_checkpoint() will decide to free the transaction
because it isn't (yet) a committing transaction and soon we fail some
assertion - the transaction really isn't ready to be freed :).

We change the check in __journal_remove_checkpoint() to free only a
transaction in T_FINISHED state.  The locking there is subtle though (as
everywhere in JBD ;().  We use j_list_lock to protect the check and a
subsequent call to __journal_drop_transaction() and do the same in the end
of journal_commit_transaction() which is the only place where a transaction
can get to T_FINISHED state.

Probably I'm too paranoid here and such locking is not really necessary -
checkpoint lists are processed only from log_do_checkpoint() where a
transaction must be already committed to be processed or from
__journal_clean_checkpoint_list() where kjournald itself calls it and thus
transaction cannot change state either.  Better be safe if something
changes in future...

Signed-off-by: Jan Kara <jack@suse.cz>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2007-12-05 09:21:20 -08:00
..
2007-10-14 20:17:39 -07:00
2007-10-17 22:51:13 +02:00
2007-10-17 08:43:03 -07:00
2007-10-10 16:53:11 -07:00
2007-10-15 17:56:36 -07:00
2007-09-11 04:22:16 -07:00
2007-10-18 14:37:20 -07:00
2007-10-10 16:51:59 -07:00
2007-11-05 18:10:28 -05:00
2007-10-21 02:37:45 -04:00
2007-10-17 08:42:45 -07:00
2007-10-17 08:43:07 -07:00
2007-10-18 14:37:29 -07:00
2007-10-19 11:53:42 -07:00
2007-10-19 11:53:42 -07:00
2007-07-31 10:43:05 -05:00
2007-10-16 09:42:58 -07:00
2007-10-20 03:10:57 +02:00
2007-10-19 11:53:36 -07:00
2007-10-19 11:53:36 -07:00
2007-10-16 09:43:13 -07:00
2007-10-17 08:42:52 -07:00
2007-11-19 21:43:22 -05:00
2007-10-19 23:07:36 +02:00
2007-10-16 09:43:09 -07:00
2007-10-21 02:37:45 -04:00
2007-10-19 11:53:36 -07:00
2007-11-02 08:47:25 +01:00
2007-10-20 02:00:58 +01:00
2007-10-18 14:37:21 -07:00
2007-10-22 08:13:19 -07:00
2007-10-22 08:13:20 -07:00
2007-10-17 08:42:51 -07:00
2007-10-29 07:41:32 -07:00
2007-10-22 08:13:21 -07:00
2007-10-17 08:43:02 -07:00
2007-10-17 08:42:48 -07:00
2007-10-17 08:43:01 -07:00
2007-11-29 09:24:54 -08:00
2007-10-19 11:53:42 -07:00
2007-11-14 18:45:40 -08:00
2007-11-15 19:24:02 +01:00
2007-10-16 11:21:00 +02:00
2007-10-22 00:56:52 -04:00
2007-10-10 16:51:59 -07:00
2007-10-17 08:42:52 -07:00
2007-10-10 16:52:04 -07:00
2007-10-14 12:41:52 -07:00
2007-10-16 09:43:01 -07:00
2007-10-18 14:37:32 -07:00
2007-07-31 15:39:41 -07:00
2007-10-16 09:42:49 -07:00
2007-11-05 15:12:32 -08:00
2007-10-17 08:42:52 -07:00
2007-11-29 09:24:52 -08:00
2007-10-17 08:43:01 -07:00
2007-10-19 11:53:49 -07:00
2007-10-12 14:51:12 -07:00
2007-10-16 09:43:10 -07:00
2007-10-13 10:18:29 +02:00
2007-09-11 22:24:45 +01:00
2007-10-25 15:02:50 +10:00
2007-10-25 15:02:50 +10:00
2007-10-19 11:53:55 -07:00
2007-10-10 16:54:03 -07:00
2007-10-17 08:42:55 -07:00
2007-10-23 15:49:54 +10:00
2007-10-19 11:53:54 -07:00
2007-10-19 11:53:44 -07:00
2007-11-07 04:15:12 -08:00
2007-10-09 17:15:11 -04:00
2007-10-17 08:42:58 -07:00
2007-10-19 11:53:34 -07:00
2007-10-19 11:53:41 -07:00
2007-10-16 09:43:02 -07:00
2007-11-23 20:54:01 -05:00
2007-10-17 08:42:44 -07:00
2007-10-19 11:53:41 -07:00
2007-10-19 11:53:41 -07:00
2007-10-19 11:53:41 -07:00
2007-12-02 00:33:17 +11:00
2007-10-17 08:42:45 -07:00
2007-10-17 08:42:56 -07:00
2007-10-16 09:42:53 -07:00
2007-10-22 08:13:20 -07:00
2007-11-29 09:24:54 -08:00
2007-11-27 09:30:39 +01:00
2007-10-16 09:43:17 -07:00
2007-10-19 11:53:44 -07:00
2007-11-29 09:24:53 -08:00
2007-10-19 11:53:44 -07:00
2007-10-17 08:43:01 -07:00
2007-11-09 22:39:38 +01:00
2007-10-12 14:51:12 -07:00
2007-10-15 12:59:43 -07:00
2007-10-17 08:42:53 -07:00
2007-11-26 20:42:19 +01:00
2007-10-29 07:41:33 -07:00
2007-09-19 11:24:18 -07:00
2007-10-23 13:47:31 -05:00
2007-10-23 15:49:54 +10:00
2007-10-23 15:49:54 +10:00
2007-10-23 15:49:55 +10:00
2007-10-23 15:49:54 +10:00
2007-10-23 15:49:54 +10:00
2007-10-17 08:42:56 -07:00
2007-10-19 11:53:34 -07:00
2007-10-17 08:43:02 -07:00