Mathieu Desnoyers dc102a8fae
Markers - remove extra format argument ...
Denys Vlasenko <vda.linux@googlemail.com > :
> Not in this patch, but I noticed:
>
> #define __trace_mark(name, call_private, format, args...) \
> do { \
> static const char __mstrtab_##name[] \
> __attribute__((section("__markers_strings"))) \
> = #name "\0" format; \
> static struct marker __mark_##name \
> __attribute__((section("__markers"), aligned(8))) = \
> { __mstrtab_##name, &__mstrtab_##name[sizeof(#name)], \
> 0, 0, marker_probe_cb, \
> { __mark_empty_function, NULL}, NULL }; \
> __mark_check_format(format, ## args); \
> if (unlikely(__mark_##name.state)) { \
> (*__mark_##name.call) \
> (&__mark_##name, call_private, \
> format, ## args); \
> } \
> } while (0)
>
> In this call:
>
> (*__mark_##name.call) \
> (&__mark_##name, call_private, \
> format, ## args); \
>
> you make gcc allocate duplicate format string. You can use
> &__mstrtab_##name[sizeof(#name)] instead since it holds the same string,
> or drop ", format," above and "const char *fmt" from here:
>
> void (*call)(const struct marker *mdata, /* Probe wrapper */
> void *call_private, const char *fmt, ...);
>
> since mdata->format is the same and all callees which need it can take it there.
Very good point. I actually thought about dropping it, since it would
remove an unnecessary argument from the stack. And actually, since I now
have the marker_probe_cb sitting between the marker site and the
callbacks, there is no API change required. Thanks :)
Mathieu
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca >
CC: Denys Vlasenko <vda.linux@googlemail.com >
Signed-off-by: Ingo Molnar <mingo@elte.hu >
Signed-off-by: Thomas Gleixner <tglx@linutronix.de >
2008-05-23 22:25:27 +02:00
2008-04-30 08:29:54 -07:00
2008-04-24 14:07:46 -03:00
2008-05-18 20:49:41 +02:00
2008-04-25 13:00:11 -04:00
2008-04-19 11:29:08 +01:00
2008-04-29 13:46:50 -07:00
2008-05-01 18:59:11 +01:00
2008-05-08 01:15:21 -07:00
2008-05-21 14:08:38 -07:00
2008-04-14 11:15:54 +02:00
2008-05-21 14:08:38 -07:00
2008-05-21 14:08:38 -07:00
2008-04-25 13:00:11 -04:00
2008-04-30 08:29:33 -07:00
2008-04-02 00:43:01 -04:00
2008-04-17 23:56:30 -07:00
2008-05-19 07:34:01 -05:00
2008-02-05 03:20:13 -08:00
2008-04-29 08:06:27 -07:00
2008-05-20 14:14:15 -07:00
2008-02-08 09:22:30 -08:00
2008-02-06 10:41:02 -08:00
2008-02-06 10:41:10 -08:00
2008-04-26 23:41:04 +02:00
2008-04-20 21:47:02 -07:00
2008-04-30 08:29:54 -07:00
2008-02-05 14:33:32 +10:00
2008-04-29 08:06:00 -07:00
2008-05-01 13:08:50 -04:00
2008-03-28 22:14:15 -04:00
2008-02-06 10:12:18 -07:00
2008-03-27 14:51:39 -04:00
2008-02-24 00:27:33 -05:00
2008-03-23 22:04:31 -07:00
2008-05-14 23:24:09 -07:00
2008-05-14 23:24:09 -07:00
2008-02-08 09:22:38 -08:00
2008-02-04 13:16:39 +00:00
2008-03-04 13:41:23 +01:00
2008-04-19 19:10:33 -07:00
2008-04-28 06:28:37 -04:00
2008-04-30 08:29:50 -07:00
2008-05-16 17:23:05 -04:00
2008-04-29 09:50:34 +02:00
2008-05-13 08:02:25 -07:00
2008-04-29 08:11:16 -07:00
2008-04-29 12:36:54 -07:00
2008-04-28 08:58:25 -07:00
2008-04-22 15:16:32 -05:00
2008-04-29 08:06:01 -07:00
2008-04-28 08:58:19 -07:00
2008-04-29 13:22:56 -07:00
2008-04-30 08:29:54 -07:00
2008-04-21 09:50:08 +02:00
2008-04-29 08:06:09 -07:00
2008-04-29 08:06:10 -07:00
2008-02-03 17:45:46 +02:00
2008-05-01 08:03:59 -07:00
2008-04-30 08:29:54 -07:00
2008-04-29 08:05:59 -07:00
2008-05-01 08:03:59 -07:00
2008-02-09 23:24:09 +01:00
2008-04-30 08:42:49 -07:00
2008-05-10 19:51:16 -07:00
2008-04-30 08:29:54 -07:00
2008-04-30 08:29:54 -07:00
2008-02-26 18:42:44 -08:00
2008-04-29 08:06:06 -07:00
2008-04-30 08:29:52 -07:00
2008-04-29 08:05:59 -07:00
2008-04-28 16:27:08 -04:00
2008-03-26 00:45:26 -04:00
2008-05-13 08:02:25 -07:00
2008-04-28 08:58:19 -07:00
2008-04-30 08:29:54 -07:00
2008-04-21 10:19:23 +08:00
2008-02-03 17:45:46 +02:00
2008-02-03 15:42:53 +02:00
2008-02-08 15:33:33 -08:00
2008-04-30 08:29:54 -07:00
2008-02-03 04:28:53 -08:00
2008-02-14 21:17:08 -08:00
2008-03-04 14:47:06 -08:00
2008-04-30 08:29:53 -07:00
2008-03-04 16:35:12 -08:00
2008-04-29 08:06:09 -07:00
2008-04-30 08:29:54 -07:00
2008-05-20 13:31:53 -07:00
2008-04-30 08:29:48 -07:00
2008-04-21 11:35:39 -05:00
2008-04-21 11:22:28 -05:00
2008-04-21 11:35:39 -05:00
2008-04-21 11:22:29 -05:00
2008-02-11 11:06:35 -05:00
2008-04-25 13:26:55 +01:00
2008-04-25 13:26:55 +01:00
2008-02-08 02:09:56 +00:00
2008-04-25 13:26:55 +01:00
2008-04-29 08:06:11 -07:00
2008-04-29 08:06:11 -07:00
2008-04-21 22:38:45 +00:00
2008-02-08 09:22:24 -08:00
2008-04-28 08:58:30 -07:00
2008-02-07 08:42:06 -08:00
2008-04-29 08:06:26 -07:00
2008-04-19 19:19:54 +02:00
2008-02-08 09:22:30 -08:00
2008-04-29 08:06:16 -07:00
2008-02-29 08:06:37 -08:00
2008-02-07 08:42:30 -08:00
2008-04-19 19:10:33 -07:00
2008-02-07 08:42:25 -08:00
2008-02-13 16:21:19 -08:00
2008-03-07 11:11:13 -08:00
2008-04-30 08:29:54 -07:00
2008-05-07 09:48:23 +02:00
2008-02-07 08:42:27 -08:00
2008-04-28 08:58:35 -07:00
2008-05-16 17:22:26 -04:00
2008-05-01 13:08:16 -04:00
2008-04-10 02:02:28 -07:00
2008-03-10 16:33:33 -07:00
2008-02-14 21:13:33 -08:00
2008-05-07 09:29:00 +02:00
2008-04-30 08:29:54 -07:00
2008-04-30 08:29:54 -07:00
2008-05-23 21:04:20 +02:00
2008-05-13 08:02:26 -07:00
2008-02-23 17:12:15 -08:00
2008-04-30 08:29:45 -07:00
2008-05-14 10:37:57 -07:00
2008-04-29 08:05:58 -07:00
2008-03-04 16:35:10 -08:00
2008-05-10 20:58:02 -07:00
2008-02-06 10:41:00 -08:00
2008-02-07 08:42:34 -08:00
2008-02-05 13:31:39 -05:00
2008-04-18 00:46:24 +02:00
2008-05-20 16:44:43 +02:00
2008-05-20 16:44:43 +02:00
2008-04-22 11:34:59 +02:00
2008-02-05 09:44:19 -08:00
2008-04-18 22:22:54 -04:00
2008-04-04 18:36:49 +02:00
2008-05-03 18:11:48 +02:00
2008-04-28 08:58:25 -07:00
2008-04-30 08:29:54 -07:00
2008-04-22 22:16:46 +02:00
2008-04-29 23:11:38 +02:00
2008-04-22 22:16:46 +02:00
2008-05-18 20:49:41 +02:00
2008-04-30 08:29:54 -07:00
2008-03-05 20:58:10 -08:00
2008-05-14 23:06:16 +02:00
2008-04-29 08:06:25 -07:00
2008-04-30 20:34:26 -04:00
2008-03-03 12:20:57 -08:00
2008-05-02 16:53:33 -07:00
2008-02-23 20:09:11 -08:00
2008-04-30 08:29:54 -07:00
2008-04-18 22:16:54 -04:00
2008-04-12 18:48:58 -07:00
2008-04-03 10:06:00 +09:00
2008-04-16 00:48:04 -07:00
2008-03-23 22:05:44 -07:00
2008-04-12 13:43:19 +09:00
2008-03-17 22:48:46 -07:00
2008-04-30 08:29:54 -07:00
2008-03-26 04:39:53 +09:00
2008-05-16 17:22:20 -04:00
2008-04-29 08:06:03 -07:00
2008-04-02 00:41:00 -04:00
2008-04-29 08:06:02 -07:00
2008-05-05 16:47:14 +10:00
2008-04-15 09:25:33 +02:00
2008-03-04 16:35:17 -08:00
2008-04-20 21:47:08 -07:00
2008-05-07 09:51:23 +02:00
2008-04-29 08:06:13 -07:00
2008-02-08 09:22:23 -08:00
2008-04-29 08:06:15 -07:00
2008-04-29 08:06:15 -07:00
2008-04-14 02:30:23 -07:00
2008-05-02 13:40:34 +02:00
2008-05-23 20:32:54 +02:00
2008-04-29 03:22:15 -04:00
2008-04-19 19:10:28 -07:00
2008-04-15 00:30:16 -07:00
2008-04-30 08:29:54 -07:00
2008-02-07 08:42:34 -08:00
2008-04-18 22:16:54 -04:00
2008-04-18 22:16:54 -04:00
2008-05-01 08:03:58 -07:00
2008-05-15 17:50:37 -07:00
2008-05-20 17:23:03 -07:00
2008-04-29 08:06:29 -07:00
2008-05-14 19:11:14 -07:00
2008-04-18 22:16:54 -04:00
2008-02-07 08:42:25 -08:00
2008-04-29 08:06:17 -07:00
2008-04-15 01:30:32 -04:00
2008-04-29 08:06:16 -07:00
2008-04-30 08:29:54 -07:00
2008-05-05 07:13:21 -05:00
2008-04-30 16:52:58 -07:00
2008-04-30 08:29:54 -07:00
2008-04-30 08:29:54 -07:00
2008-04-28 08:58:32 -07:00
2008-04-30 08:29:54 -07:00
2008-04-19 19:44:57 +02:00
2008-04-27 18:21:46 +03:00
2008-04-27 12:00:27 +03:00
2008-04-27 12:01:15 +03:00
2008-04-27 18:21:37 +03:00
2008-04-24 23:49:30 +01:00
2008-03-28 11:05:54 +11:00
2008-05-19 17:51:48 -04:00
2008-05-23 20:31:27 +02:00
2008-04-30 08:29:54 -07:00
2008-02-03 17:45:46 +02:00
2008-03-31 10:41:44 +01:00
2008-04-29 15:57:53 +10:00
2008-02-06 10:41:03 -08:00
2008-02-06 10:41:01 -08:00
2008-02-06 10:41:01 -08:00
2008-02-26 14:03:47 +09:00
2008-05-23 22:25:27 +02:00
2008-05-01 08:03:58 -07:00
2008-04-15 19:35:41 -07:00
2008-03-27 14:51:39 -04:00
2008-04-29 08:06:01 -07:00
2008-04-29 08:06:10 -07:00
2008-04-28 08:58:25 -07:00
2008-04-29 08:06:12 -07:00
2008-04-28 08:58:25 -07:00
2008-04-19 19:10:29 -07:00
2008-04-24 14:07:43 -03:00
2008-04-19 19:10:28 -07:00
2008-05-13 08:02:25 -07:00
2008-04-29 08:06:17 -07:00
2008-04-30 08:29:54 -07:00
2008-04-23 00:05:03 -04:00
2008-04-29 23:11:39 +02:00
2008-05-01 21:14:59 +10:00
2008-02-13 16:21:19 -08:00
2008-04-30 08:29:54 -07:00
2008-04-13 23:21:16 -07:00
2008-04-04 10:44:42 +09:00
2008-04-28 08:58:47 -07:00
2008-04-29 08:06:12 -07:00
2008-04-29 09:11:12 -07:00
2008-04-07 12:15:39 -05:00
2008-02-13 16:21:18 -08:00
2008-02-08 09:22:31 -08:00
2008-04-28 21:17:07 -07:00
2008-02-14 21:13:33 -08:00
2008-04-29 08:06:24 -07:00
2008-04-30 08:29:54 -07:00
2008-04-28 08:58:29 -07:00
2008-03-22 17:18:47 -07:00
2008-05-20 14:54:50 -07:00
2008-04-14 11:15:52 +02:00
2008-05-21 14:08:38 -07:00
2008-04-28 06:18:03 -04:00
2008-03-04 12:28:49 -08:00
2008-04-23 16:13:37 -04:00
2008-04-19 16:54:56 -04:00
2008-04-19 16:55:29 -04:00
2008-04-19 16:53:15 -04:00
2008-02-01 16:42:05 -05:00
2008-03-06 15:30:41 -05:00
2008-04-28 08:58:19 -07:00
2008-04-29 08:06:13 -07:00
2008-02-05 09:44:24 -08:00
2008-04-30 08:29:54 -07:00
2008-04-17 07:46:11 +10:00
2008-05-09 20:22:58 +10:00
2008-04-07 13:49:23 +10:00
2008-04-28 08:58:18 -07:00
2008-04-28 08:58:22 -07:00
2008-02-13 16:21:18 -08:00
2008-04-18 22:22:54 -04:00
2008-05-14 19:23:25 -05:00
2008-02-14 21:13:33 -08:00
2008-05-01 08:04:01 -07:00
2008-04-20 21:47:03 -07:00
2008-02-01 15:04:29 -08:00
2008-04-20 21:47:03 -07:00
2008-04-29 15:34:05 -07:00
2008-05-03 03:39:55 +04:00
2008-05-14 19:11:14 -07:00
2008-04-29 08:06:02 -07:00
2008-02-07 23:11:56 -08:00
2008-04-29 08:06:02 -07:00
2008-05-06 12:01:41 -04:00
2008-04-30 08:29:49 -07:00
2008-04-30 08:29:49 -07:00
2008-04-04 10:44:42 +09:00
2008-03-17 22:46:46 -07:00
2008-02-05 09:44:22 -08:00
2008-04-19 19:10:26 -07:00
2008-04-30 08:29:54 -07:00
2008-03-13 10:09:27 +11:00
2008-04-30 11:52:52 -07:00
2008-04-30 08:29:53 -07:00
2008-05-01 13:07:28 -04:00
2008-02-05 21:15:50 -05:00
2008-04-28 08:58:26 -07:00
2008-05-23 20:32:54 +02:00
2008-04-29 08:06:20 -07:00
2008-04-30 08:29:54 -07:00
2008-04-30 08:29:50 -07:00
2008-04-30 08:29:38 -07:00
2008-02-07 08:42:28 -08:00
2008-05-01 08:04:01 -07:00
2008-04-28 08:58:33 -07:00
2008-02-03 16:12:47 +02:00
2008-04-19 19:10:33 -07:00
2008-04-30 08:29:54 -07:00
2008-05-10 19:51:16 -07:00
2008-04-30 08:29:54 -07:00
2008-04-30 08:29:54 -07:00
2008-02-05 09:44:22 -08:00
2008-04-30 08:29:51 -07:00
2008-04-28 08:58:46 -07:00
2008-04-29 08:06:10 -07:00
2008-04-29 08:05:59 -07:00
2008-04-30 08:29:54 -07:00
2008-05-03 10:01:33 -07:00
2008-02-07 08:42:19 -08:00
2008-04-23 22:10:48 -07:00
2008-02-13 16:21:18 -08:00
2008-04-30 08:29:54 -07:00
2008-04-07 12:15:45 -05:00
2008-05-23 21:08:47 +02:00
2008-02-05 10:59:07 -05:00
2008-04-28 08:58:26 -07:00
2008-04-29 08:06:16 -07:00
2008-04-19 09:53:46 +10:00
2008-04-17 10:43:01 -04:00
2008-04-02 00:10:28 -07:00
2008-04-30 08:29:54 -07:00
2008-04-25 00:25:08 +02:00
2008-02-07 08:42:34 -08:00
2008-04-28 08:58:32 -07:00
2008-04-30 08:29:30 -07:00
2008-02-26 14:52:45 +09:00
2008-04-15 13:26:52 -04:00
2008-02-07 08:42:30 -08:00
2008-04-28 08:58:25 -07:00
2008-04-30 08:29:34 -07:00
2008-02-03 15:12:15 +02:00
2008-04-21 15:51:36 -07:00
2008-03-06 16:21:49 -08:00
2008-04-30 08:29:54 -07:00
2008-04-27 18:28:18 +03:00
2008-03-04 16:35:13 -08:00
2008-03-04 16:35:13 -08:00
2008-04-30 08:29:54 -07:00
2008-04-30 08:29:54 -07:00
2008-04-29 08:06:05 -07:00
2008-03-17 07:49:27 -04:00
2008-02-03 17:45:46 +02:00
2008-04-17 12:22:31 +02:00
2008-02-07 08:42:34 -08:00
2008-05-01 08:03:59 -07:00
2008-02-01 18:30:53 -05:00
2008-04-28 08:58:36 -07:00
2008-04-30 08:29:54 -07:00
2008-04-28 08:58:20 -07:00
2008-02-09 11:08:33 -08:00
2008-04-28 08:58:29 -07:00
2008-04-29 08:06:06 -07:00
2008-04-29 08:06:23 -07:00
2008-04-19 19:44:59 +02:00
2008-05-04 17:07:03 -07:00
2008-04-29 08:06:27 -07:00
2008-05-21 17:40:05 -07:00
2008-04-30 08:29:54 -07:00
2008-04-29 02:48:01 -04:00
2008-04-30 08:29:37 -07:00
2008-02-01 17:45:14 +01:00
2008-03-10 18:01:18 -07:00
2008-03-09 08:42:57 +01:00
2008-04-30 08:29:53 -07:00
2008-05-01 08:03:59 -07:00
2008-04-19 19:44:59 +02:00
2008-04-19 19:10:33 -07:00
2008-04-30 08:29:47 -07:00
2008-04-30 08:29:47 -07:00
2008-02-08 09:22:39 -08:00
2008-04-17 20:05:36 +02:00
2008-04-17 14:22:23 +02:00
2008-03-23 22:06:51 -07:00
2008-04-24 21:16:42 -07:00
2008-04-24 21:16:57 -07:00
2008-04-24 21:16:54 -07:00
2008-02-08 09:22:23 -08:00
2008-05-09 07:45:18 -07:00
2008-04-24 14:07:56 -03:00
2008-02-18 12:18:05 -03:00
2008-02-04 23:50:13 +11:00
2008-05-02 21:50:51 +10:00
2008-05-02 21:50:50 +10:00
2008-05-02 21:50:47 +10:00
2008-02-04 23:50:12 +11:00
2008-02-04 23:50:00 +11:00
2008-05-02 21:50:50 +10:00
2008-04-28 08:58:21 -07:00
2008-04-28 08:58:23 -07:00
2008-02-06 10:41:03 -08:00
2008-02-06 10:41:15 -08:00
2008-02-13 16:21:18 -08:00
2008-05-01 17:38:35 -04:00
2008-04-17 09:24:58 -04:00
2008-02-13 16:21:18 -08:00
2008-05-23 22:05:14 +02:00
2008-04-29 08:06:06 -07:00
2008-04-25 00:29:34 -07:00
dc102a8fae