Jan Kara de1b794130
jbd2: Fix oops in jbd2_journal_remove_journal_head() ...
jbd2_journal_remove_journal_head() can oops when trying to access
journal_head returned by bh2jh(). This is caused for example by the
following race:
TASK1 TASK2
jbd2_journal_commit_transaction()
...
processing t_forget list
__jbd2_journal_refile_buffer(jh);
if (!jh->b_transaction) {
jbd_unlock_bh_state(bh);
jbd2_journal_try_to_free_buffers()
jbd2_journal_grab_journal_head(bh)
jbd_lock_bh_state(bh)
__journal_try_to_free_buffer()
jbd2_journal_put_journal_head(jh)
jbd2_journal_remove_journal_head(bh);
jbd2_journal_put_journal_head() in TASK2 sees that b_jcount == 0 and
buffer is not part of any transaction and thus frees journal_head
before TASK1 gets to doing so. Note that even buffer_head can be
released by try_to_free_buffers() after
jbd2_journal_put_journal_head() which adds even larger opportunity for
oops (but I didn't see this happen in reality).
Fix the problem by making transactions hold their own journal_head
reference (in b_jcount). That way we don't have to remove journal_head
explicitely via jbd2_journal_remove_journal_head() and instead just
remove journal_head when b_jcount drops to zero. The result of this is
that [__]jbd2_journal_refile_buffer(),
[__]jbd2_journal_unfile_buffer(), and
__jdb2_journal_remove_checkpoint() can free journal_head which needs
modification of a few callers. Also we have to be careful because once
journal_head is removed, buffer_head might be freed as well. So we
have to get our own buffer_head reference where it matters.
Signed-off-by: Jan Kara <jack@suse.cz >
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu >
2011-06-13 15:38:22 -04:00
2011-03-31 11:26:23 -03:00
2011-05-11 14:50:41 -04:00
2011-05-04 14:08:36 -07:00
2011-05-24 11:52:05 -07:00
2011-03-31 11:26:23 -03:00
2011-05-20 18:51:09 -03:00
2011-05-26 19:45:40 +02:00
2011-05-26 19:45:54 +02:00
2011-03-31 11:26:23 -03:00
2011-05-27 10:49:29 +01:00
2011-03-23 12:24:23 -07:00
2011-05-25 16:55:55 -07:00
2011-05-27 20:06:53 -07:00
2011-05-26 19:08:05 +02:00
2011-03-31 11:26:23 -03:00
2011-03-31 11:26:23 -03:00
2011-03-16 15:11:04 -07:00
2011-04-20 17:48:49 +04:00
2011-03-31 11:26:23 -03:00
2011-05-27 10:34:37 +01:00
2011-05-26 12:13:22 -07:00
2011-05-20 13:43:21 -07:00
2011-05-29 14:10:13 -07:00
2011-05-23 12:33:02 -07:00
2011-03-31 11:26:23 -03:00
2011-02-24 19:58:42 +01:00
2011-04-01 02:24:31 -04:00
2011-03-21 22:59:08 -04:00
2011-04-28 13:39:17 -07:00
2011-03-15 02:42:32 -04:00
2011-04-25 14:50:08 -04:00
2011-03-30 16:53:38 -07:00
2011-05-28 17:41:46 +02:00
2011-03-10 08:52:07 +01:00
2011-03-22 17:43:59 -07:00
2011-05-20 00:40:19 -06:00
2011-03-11 14:25:50 +00:00
2011-04-09 15:53:56 +02:00
2011-03-08 08:28:01 +01:00
2011-04-25 18:10:58 -07:00
2011-05-25 08:39:45 -07:00
2011-05-26 17:12:38 -07:00
2011-05-20 20:52:16 +02:00
2011-05-20 20:33:15 +02:00
2011-03-03 10:53:20 -05:00
2011-05-25 08:39:30 -07:00
2011-05-19 16:55:27 +09:30
2011-05-26 07:26:45 -04:00
2011-05-25 08:39:43 -07:00
2011-05-24 22:55:24 +10:00
2011-03-31 11:26:23 -03:00
2011-03-31 11:26:23 -03:00
2011-05-26 17:12:34 -07:00
2011-05-26 17:12:34 -07:00
2011-05-26 10:01:36 -06:00
2011-05-19 14:24:16 +02:00
2011-05-23 18:04:51 +01:00
2011-03-31 11:26:23 -03:00
2011-03-22 17:44:00 -07:00
2011-05-24 08:55:20 -04:00
2011-03-22 17:44:10 -07:00
2011-05-25 08:39:47 -07:00
2011-05-25 08:39:46 -07:00
2011-03-31 11:26:23 -03:00
2011-03-30 17:14:33 -07:00
2011-03-31 11:26:23 -03:00
2011-05-04 11:50:57 -04:00
2011-05-25 08:39:45 -07:00
2011-05-28 17:02:57 +02:00
2011-05-26 17:12:37 -07:00
2011-03-22 17:44:15 -07:00
2011-05-19 15:59:38 -07:00
2011-03-22 19:25:05 -07:00
2011-04-24 07:58:46 -07:00
2011-03-14 17:02:43 -07:00
2011-03-08 16:10:38 +01:00
2011-05-29 12:52:55 +01:00
2011-05-19 18:24:11 -07:00
2011-05-23 10:47:06 -05:00
2011-05-29 13:03:09 +01:00
2011-03-24 13:54:30 +00:00
2011-05-29 13:03:13 +01:00
2011-03-31 11:26:23 -03:00
2011-02-25 12:00:34 -08:00
2011-03-31 11:26:23 -03:00
2011-03-10 11:35:17 +01:00
2011-05-24 10:21:29 +02:00
2011-05-24 10:21:29 +02:00
2011-05-25 18:30:37 +05:30
2011-04-04 12:48:08 -04:00
2011-05-25 17:03:53 -07:00
2011-04-05 23:51:37 +02:00
2011-05-14 21:36:55 +01:00
2011-03-22 17:44:11 -07:00
2011-05-13 14:37:28 -04:00
2011-03-31 11:26:23 -03:00
2011-03-31 11:26:23 -03:00
2011-05-27 07:04:40 -04:00
2011-05-12 07:37:51 -07:00
2011-03-14 19:12:20 -04:00
2011-03-15 02:21:45 -04:00
2011-05-22 21:01:22 -04:00
2011-03-31 11:26:23 -03:00
2011-05-10 22:53:46 +02:00
2011-05-26 17:12:33 -07:00
2011-05-28 12:02:09 -04:00
2011-05-25 08:39:44 -07:00
2011-03-31 11:26:23 -03:00
2011-05-02 16:59:38 -07:00
2011-05-25 22:13:44 -04:00
2011-05-18 19:22:52 -04:00
2011-05-25 08:39:54 -07:00
2011-05-06 19:30:02 -06:00
2011-05-25 08:39:11 -07:00
2011-04-11 23:53:19 -07:00
2011-05-27 17:56:45 -06:00
2011-03-05 10:56:00 +01:00
2011-03-31 11:26:23 -03:00
2011-03-31 11:26:23 -03:00
2011-05-23 13:59:54 +02:00
2011-05-25 08:39:19 -07:00
2011-05-26 09:20:31 -07:00
2011-05-26 12:03:50 -07:00
2011-05-25 20:43:32 +02:00
2011-03-31 11:26:23 -03:00
2011-03-12 15:08:54 -08:00
2011-05-08 16:41:45 -07:00
2011-05-11 14:44:48 -04:00
2011-05-27 13:40:54 -04:00
2011-05-10 14:36:03 -07:00
2011-03-18 15:14:45 -07:00
2011-05-25 17:55:23 -04:00
2011-02-27 16:11:51 -08:00
2011-03-10 16:37:26 -08:00
2011-05-26 17:12:34 -07:00
2011-05-16 14:46:30 -04:00
2011-04-18 13:29:03 -07:00
2011-05-05 23:16:54 -07:00
2011-03-23 19:47:08 -07:00
2011-05-26 17:12:37 -07:00
2011-03-31 11:26:23 -03:00
2011-04-23 15:56:24 +02:00
2011-05-18 14:59:08 +02:00
2011-03-31 11:26:23 -03:00
2011-06-13 15:38:22 -04:00
2011-03-31 11:26:23 -03:00
2011-03-20 20:08:48 -04:00
2011-04-04 12:48:08 -04:00
2011-03-24 08:36:10 +01:00
2011-03-22 16:17:32 -07:00
2011-05-25 16:55:55 -07:00
2011-05-25 08:39:52 -07:00
2011-04-01 16:14:30 +11:00
2011-03-08 11:17:18 +11:00
2011-05-27 10:25:02 -07:00
2011-03-08 11:17:22 +11:00
2011-03-18 16:54:31 +00:00
2011-05-24 22:55:24 +10:00
2011-03-22 17:44:01 -07:00
2011-03-31 11:26:23 -03:00
2011-05-23 15:39:34 -07:00
2011-05-22 08:47:53 -04:00
2011-03-31 11:26:23 -03:00
2011-05-25 08:39:50 -07:00
2011-04-13 11:11:43 +02:00
2011-05-25 08:39:51 -07:00
2011-05-19 20:50:53 -04:00
2011-05-24 14:33:35 +02:00
2011-04-25 18:14:10 -07:00
2011-05-19 14:15:29 -07:00
2011-05-25 08:39:17 -07:00
2011-05-24 10:01:37 +02:00
2011-04-25 18:14:07 -04:00
2011-03-18 22:33:38 -07:00
2011-03-22 04:53:56 -03:00
2011-05-25 08:39:48 -07:00
2011-05-26 17:12:36 -07:00
2011-05-25 08:39:34 -07:00
2011-05-29 11:32:28 -07:00
2011-05-26 17:12:36 -07:00
2011-05-25 08:39:19 -07:00
2011-05-27 19:51:32 -07:00
2011-05-10 15:54:54 -04:00
2011-05-19 16:55:27 +09:30
2011-05-19 16:55:25 +09:30
2011-03-31 11:26:23 -03:00
2011-05-04 12:18:54 -07:00
2011-03-02 13:43:15 -08:00
2011-05-25 08:39:17 -07:00
2011-05-09 11:40:38 +10:00
2011-03-18 09:04:20 -04:00
2011-05-27 13:41:33 -04:00
2011-05-20 00:33:18 -04:00
2011-05-27 13:40:58 -04:00
2011-05-20 11:46:11 -07:00
2011-05-29 14:10:13 -07:00
2011-04-24 14:28:18 -04:00
2011-03-23 15:29:04 -04:00
2011-03-11 15:39:26 -05:00
2011-03-11 15:38:44 -05:00
2011-05-29 20:56:54 +03:00
2011-05-29 20:54:36 +03:00
2011-05-10 22:21:45 +09:00
2011-05-16 19:32:19 -04:00
2011-05-23 11:58:59 +02:00
2011-05-22 21:01:19 -04:00
2011-05-26 17:12:34 -07:00
2011-05-18 12:32:23 -06:00
2011-04-20 17:01:19 +10:00
2011-03-23 14:55:56 -06:00
2011-03-16 17:28:10 -07:00
2011-03-31 11:26:23 -03:00
2011-05-25 08:39:10 -07:00
2011-03-31 11:26:23 -03:00
2011-05-29 12:40:51 +02:00
2011-05-25 08:39:25 -07:00
2011-03-14 02:58:03 -04:00
2011-05-26 16:24:48 -07:00
2011-05-11 15:18:53 -07:00
2011-05-21 12:16:44 -07:00
2011-04-11 09:01:41 +02:00
2011-05-24 12:06:40 -07:00
2011-05-25 08:39:54 -07:00
2011-05-04 14:20:20 -07:00
2011-05-06 21:07:38 +02:00
2011-03-09 11:59:33 -08:00
2011-05-26 17:12:37 -07:00
2011-04-11 13:44:25 -07:00
2011-05-16 20:17:47 +02:00
2011-03-11 15:13:26 -05:00
2011-05-29 00:50:59 -04:00
2011-04-30 00:25:44 +02:00
2011-03-15 00:43:14 +01:00
2011-05-17 23:26:21 +02:00
2011-05-29 20:52:36 +03:00
2011-03-31 11:26:23 -03:00
2011-05-10 10:16:21 +02:00
2011-05-24 12:10:51 +02:00
2011-03-01 22:27:26 +03:00
2011-03-31 11:26:23 -03:00
2011-05-25 08:39:48 -07:00
2011-05-26 17:12:36 -07:00
2011-05-16 11:05:00 -07:00
2011-05-13 16:31:00 -07:00
2011-05-23 13:01:00 -07:00
2011-05-23 13:01:00 -07:00
2011-05-23 13:01:00 -07:00
2011-04-25 17:28:24 +02:00
2011-03-22 17:44:00 -07:00
2011-03-31 11:26:23 -03:00
2011-03-24 21:16:31 -04:00
2011-05-26 15:00:31 -04:00
2011-04-26 14:01:42 -07:00
2011-05-19 14:15:29 -07:00
2011-05-05 23:16:59 -07:00
2011-05-05 23:16:59 -07:00
2011-05-05 23:16:59 -07:00
2011-03-31 11:26:23 -03:00
2011-03-23 19:46:23 -07:00
2011-05-19 13:53:54 -04:00
2011-04-19 15:38:02 -04:00
2011-03-09 13:52:27 -05:00
2011-03-23 19:46:41 -07:00
2011-04-14 16:06:56 -07:00
2011-02-25 15:07:37 -08:00
2011-04-14 16:06:56 -07:00
2011-05-25 08:39:19 -07:00
2011-05-12 08:28:47 -07:00
2011-05-26 17:12:33 -07:00
2011-05-29 11:32:28 -07:00
2011-04-25 10:20:32 -04:00
2011-05-24 15:22:17 +02:00
2011-05-19 16:51:01 -07:00
2011-05-19 16:51:02 -07:00
2011-05-25 08:39:31 -07:00
2011-05-19 08:19:36 -07:00
2011-03-22 17:44:15 -07:00
2011-05-20 13:33:21 -07:00
2011-05-23 08:39:24 -07:00
2011-05-21 12:53:53 +03:00
2011-03-22 17:16:34 +09:00
2011-03-31 11:26:23 -03:00
2011-05-26 13:38:58 +10:00
2011-04-13 17:13:00 -07:00
2011-05-05 11:10:14 -07:00
2011-03-09 14:08:09 -08:00
2011-03-28 06:05:24 -04:00
2011-03-31 11:26:23 -03:00
2011-05-20 12:51:07 -07:00
2011-03-31 11:26:23 -03:00
2011-05-03 16:09:40 -07:00
2011-03-31 11:26:23 -03:00
2011-05-19 16:55:28 +09:30
2011-04-11 22:54:42 +02:00
2011-03-22 15:47:22 +09:00
2011-05-26 17:12:35 -07:00
2011-05-25 18:10:16 -07:00
2011-03-15 00:43:46 +01:00
2011-03-09 16:43:24 -08:00
2011-05-11 21:37:15 +02:00
2011-05-13 16:05:51 -07:00
2011-02-28 18:00:31 -08:00
2011-05-23 13:59:54 +02:00
2011-04-22 17:01:09 -07:00
2011-05-23 13:59:53 +02:00
2011-05-23 13:59:53 +02:00
2011-04-26 14:01:42 -07:00
2011-03-13 16:35:18 -04:00
2011-05-10 16:03:56 -04:00
2011-05-20 13:33:21 -07:00
2011-04-04 12:48:08 -04:00
2011-04-22 17:31:53 -07:00
2011-05-13 16:31:00 -07:00
2011-03-22 17:44:09 -07:00
2011-05-25 19:56:23 -04:00
2011-03-31 11:26:23 -03:00
2011-04-29 17:24:29 -07:00
2011-03-23 19:47:03 -07:00
2011-05-20 09:30:46 -03:00
2011-03-31 11:26:23 -03:00
2011-05-20 11:28:49 -03:00
2011-03-22 04:53:33 -03:00
2011-03-31 11:26:23 -03:00
2011-05-20 12:17:35 -03:00
2011-05-26 17:12:34 -07:00
2011-03-28 12:53:29 +01:00
2011-05-26 17:12:34 -07:00
2011-03-31 11:26:23 -03:00
2011-04-19 16:49:20 +03:00
2011-03-24 21:17:51 -04:00
2011-05-25 08:39:45 -07:00
2011-03-13 20:22:28 -07:00
2011-03-31 11:26:23 -03:00
2011-03-22 17:44:17 -07:00
de1b794130