Ulrich Drepper ed8cae8ba0
flag parameters: pipe ...
This patch introduces the new syscall pipe2 which is like pipe but it also
takes an additional parameter which takes a flag value. This patch implements
the handling of O_CLOEXEC for the flag. I did not add support for the new
syscall for the architectures which have a special sys_pipe implementation. I
think the maintainers of those archs have the chance to go with the unified
implementation but that's up to them.
The implementation introduces do_pipe_flags. I did that instead of changing
all callers of do_pipe because some of the callers are written in assembler.
I would probably screw up changing the assembly code. To avoid breaking code
do_pipe is now a small wrapper around do_pipe_flags. Once all callers are
changed over to do_pipe_flags the old do_pipe function can be removed.
The following test must be adjusted for architectures other than x86 and
x86-64 and in case the syscall numbers changed.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
#include <fcntl.h>
#include <stdio.h>
#include <unistd.h>
#include <sys/syscall.h>
#ifndef __NR_pipe2
# ifdef __x86_64__
# define __NR_pipe2 293
# elif defined __i386__
# define __NR_pipe2 331
# else
# error "need __NR_pipe2"
# endif
#endif
int
main (void)
{
int fd[2];
if (syscall (__NR_pipe2, fd, 0) != 0)
{
puts ("pipe2(0) failed");
return 1;
}
for (int i = 0; i < 2; ++i)
{
int coe = fcntl (fd[i], F_GETFD);
if (coe == -1)
{
puts ("fcntl failed");
return 1;
}
if (coe & FD_CLOEXEC)
{
printf ("pipe2(0) set close-on-exit for fd[%d]\n", i);
return 1;
}
}
close (fd[0]);
close (fd[1]);
if (syscall (__NR_pipe2, fd, O_CLOEXEC) != 0)
{
puts ("pipe2(O_CLOEXEC) failed");
return 1;
}
for (int i = 0; i < 2; ++i)
{
int coe = fcntl (fd[i], F_GETFD);
if (coe == -1)
{
puts ("fcntl failed");
return 1;
}
if ((coe & FD_CLOEXEC) == 0)
{
printf ("pipe2(O_CLOEXEC) does not set close-on-exit for fd[%d]\n", i);
return 1;
}
}
close (fd[0]);
close (fd[1]);
puts ("OK");
return 0;
}
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Ulrich Drepper <drepper@redhat.com >
Acked-by: Davide Libenzi <davidel@xmailserver.org >
Cc: Michael Kerrisk <mtk.manpages@googlemail.com >
Cc: <linux-arch@vger.kernel.org >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2008-07-24 10:47:28 -07:00
2008-07-14 22:38:35 +02:00
2008-07-15 16:11:29 -04:00
2008-07-23 18:24:08 -07:00
2008-07-14 23:48:48 -07:00
2008-07-16 15:17:52 -07:00
2008-07-21 21:55:03 -07:00
2008-07-21 10:11:00 -07:00
2008-05-21 14:08:38 -07:00
2008-06-09 15:55:45 -07:00
2008-05-21 14:08:38 -07:00
2008-05-21 14:08:38 -07:00
2008-06-23 13:02:50 -04:00
2008-07-21 17:05:25 +10:00
2008-07-22 13:13:47 -07:00
2008-07-14 14:52:56 -04:00
2008-07-20 21:21:46 -07:00
2008-07-22 13:03:22 -07:00
2008-06-16 10:20:58 -07:00
2008-07-24 10:47:24 -07:00
2008-07-01 11:28:06 +10:00
2008-06-19 10:42:17 +10:00
2008-06-19 10:42:17 +10:00
2008-07-24 10:47:27 -07:00
2008-07-17 17:59:55 -07:00
2008-05-14 23:24:09 -07:00
2008-05-14 23:24:09 -07:00
2008-07-24 10:47:24 -07:00
2008-07-22 09:59:40 -07:00
2008-07-24 10:47:22 -07:00
2008-07-03 13:21:14 +02:00
2008-05-13 08:02:25 -07:00
2008-06-06 11:29:10 -07:00
2008-07-16 14:51:41 -07:00
2008-07-03 13:21:12 +02:00
2008-07-24 10:47:20 -07:00
2008-05-29 01:38:46 -07:00
2008-07-04 10:40:08 -07:00
2008-07-04 10:40:05 -07:00
2008-05-10 19:51:16 -07:00
2008-07-17 15:21:29 -07:00
2008-05-27 10:11:36 +02:00
2008-05-19 18:17:49 -04:00
2008-06-11 19:13:45 -04:00
2008-07-23 19:36:53 -07:00
2008-07-18 13:22:25 +02:00
2008-07-12 08:22:32 -05:00
2008-07-10 20:35:18 +08:00
2008-07-20 17:12:38 -07:00
2008-07-22 17:30:57 -07:00
2008-07-11 10:46:50 +02:00
2008-07-13 11:51:40 +01:00
2008-07-05 13:10:50 -07:00
2008-07-21 21:54:59 -07:00
2008-06-24 13:53:46 +02:00
2008-07-21 12:00:37 +01:00
2008-07-21 21:54:53 -07:00
2008-06-24 22:58:07 -04:00
2008-07-21 12:00:37 +01:00
2008-07-22 10:39:36 +10:00
2008-07-17 17:59:56 -07:00
2008-07-08 11:59:42 -07:00
2008-05-25 10:55:10 +02:00
2008-07-21 21:54:53 -07:00
2008-07-01 14:47:09 +10:00
2008-07-02 03:47:41 -07:00
2008-07-24 10:47:27 -07:00
2008-07-24 10:47:28 -07:00
2008-05-07 09:48:23 +02:00
2008-05-16 17:22:26 -04:00
2008-05-01 13:08:16 -04:00
2008-07-08 17:55:41 +02:00
2008-07-10 14:30:13 +01:00
2008-07-16 23:27:03 +02:00
2008-07-22 19:09:51 -07:00
2008-07-24 10:47:28 -07:00
2008-07-16 17:57:47 -05:00
2008-07-11 15:49:21 +02:00
2008-05-13 08:02:26 -07:00
2008-05-16 14:50:42 -04:00
2008-07-20 17:12:36 -07:00
2008-07-03 13:21:14 +02:00
2008-07-24 10:47:20 -07:00
2008-05-16 16:54:14 -04:00
2008-05-24 09:56:13 -07:00
2008-05-10 20:58:02 -07:00
2008-07-20 17:12:36 -07:00
2008-07-04 08:47:41 -04:00
2008-07-23 15:25:21 +02:00
2008-05-20 16:44:43 +02:00
2008-05-03 18:11:48 +02:00
2008-07-24 10:47:19 -07:00
2008-07-14 22:38:31 +02:00
2008-07-20 07:18:38 -03:00
2008-07-14 22:38:36 +02:00
2008-07-23 19:56:01 +02:00
2008-07-08 14:15:59 -04:00
2008-06-11 21:00:38 -07:00
2008-07-18 18:05:19 -07:00
2008-06-11 21:00:38 -07:00
2008-07-14 22:18:19 -07:00
2008-06-16 16:48:20 -07:00
2008-07-14 22:49:06 -07:00
2008-07-03 17:51:57 +09:00
2008-07-10 14:47:38 +01:00
2008-06-03 16:36:01 -07:00
2008-06-27 20:09:00 -07:00
2008-07-09 12:09:28 -04:00
2008-06-03 16:37:33 -07:00
2008-07-16 18:02:33 -07:00
2008-07-21 00:55:14 -04:00
2008-07-15 10:39:22 -07:00
2008-05-05 16:47:14 +10:00
2008-07-03 13:21:14 +02:00
2008-07-16 23:27:07 +02:00
2008-05-07 09:51:23 +02:00
2008-06-11 21:00:38 -07:00
2008-07-21 13:41:16 -07:00
2008-06-05 15:18:30 +02:00
2008-05-23 20:32:54 +02:00
2008-07-20 17:12:37 -07:00
2008-07-11 19:27:31 -04:00
2008-05-20 12:17:39 -04:00
2008-05-15 17:50:37 -07:00
2008-06-27 23:13:54 +02:00
2008-05-12 21:28:05 +02:00
2008-07-10 08:17:14 +02:00
2008-05-05 07:13:21 -05:00
2008-07-22 19:24:31 +10:00
2008-07-24 10:47:17 -07:00
2008-06-23 22:10:57 +02:00
2008-07-04 10:40:05 -07:00
2008-07-20 12:42:40 +03:00
2008-07-20 12:42:32 +03:00
2008-07-14 15:59:33 -04:00
2008-05-16 14:50:49 -04:00
2008-07-14 16:11:52 +02:00
2008-05-19 10:01:37 +02:00
2008-06-27 09:39:47 +01:00
2008-06-24 13:43:07 +02:00
2008-05-23 22:26:03 +02:00
2008-06-12 10:47:58 +02:00
2008-07-24 10:47:21 -07:00
2008-07-24 10:47:21 -07:00
2008-07-24 10:47:21 -07:00
2008-05-13 08:02:25 -07:00
2008-07-24 10:47:21 -07:00
2008-07-09 16:30:45 +10:00
2008-05-24 11:27:41 +02:00
2008-05-24 09:56:13 -07:00
2008-07-14 10:02:12 +02:00
2008-07-24 10:47:24 -07:00
2008-07-11 19:27:31 -04:00
2008-07-03 17:51:57 +09:00
2008-07-03 17:51:57 +09:00
2008-06-08 11:58:43 -07:00
2008-06-06 11:29:12 -07:00
2008-06-12 08:40:37 +02:00
2008-07-24 10:47:27 -07:00
2008-07-22 14:09:06 -07:00
2008-06-09 15:57:24 -07:00
2008-07-08 02:36:40 -07:00
2008-05-21 14:08:38 -07:00
2008-06-05 11:23:39 -07:00
2008-06-23 13:02:48 -04:00
2008-07-09 12:09:40 -04:00
2008-07-09 12:09:17 -04:00
2008-07-09 12:09:24 -04:00
2008-07-09 12:09:16 -04:00
2008-06-27 09:09:17 -04:00
2008-06-17 23:59:41 -04:00
2008-05-16 23:22:28 +10:00
2008-07-22 10:39:30 +10:00
2008-05-09 20:22:58 +10:00
2008-07-24 10:47:15 -07:00
2008-05-25 10:55:11 +02:00
2008-07-24 10:47:15 -07:00
2008-05-14 19:23:25 -05:00
2008-06-10 14:37:03 -07:00
2008-07-23 12:03:18 -07:00
2008-07-07 16:26:50 -07:00
2008-07-16 17:25:46 -07:00
2008-05-03 03:39:55 +04:00
2008-07-11 19:27:31 -04:00
2008-05-14 19:11:14 -07:00
2008-05-06 12:01:41 -04:00
2008-07-14 20:36:32 -07:00
2008-07-20 00:08:47 -07:00
2008-06-10 10:59:51 -07:00
2008-07-14 14:30:21 -07:00
2008-07-24 10:47:23 -07:00
2008-07-16 23:27:07 +02:00
2008-05-01 13:07:28 -04:00
2008-06-11 21:00:38 -07:00
2008-06-11 21:00:38 -07:00
2008-05-23 20:32:54 +02:00
2008-07-22 14:19:19 -07:00
2008-07-14 15:01:47 +10:00
2008-07-03 13:25:05 +01:00
2008-05-19 16:25:39 +01:00
2008-05-19 10:01:36 +02:00
2008-07-04 10:40:07 -07:00
2008-05-19 10:01:36 +02:00
2008-05-19 10:01:36 +02:00
2008-05-25 07:09:47 +02:00
2008-06-26 14:21:22 -04:00
2008-05-03 10:01:33 -07:00
2008-07-20 00:08:47 -07:00
2008-07-23 14:42:09 +02:00
2008-07-24 10:47:14 -07:00
2008-07-04 10:40:08 -07:00
2008-07-24 10:47:22 -07:00
2008-07-18 04:07:44 -07:00
2008-07-24 10:47:24 -07:00
2008-07-08 10:33:01 -04:00
2008-07-24 10:47:27 -07:00
2008-07-14 22:49:06 -07:00
2008-07-24 10:47:21 -07:00
2008-07-04 10:40:04 -07:00
2008-05-24 09:56:12 -07:00
2008-07-12 21:52:41 +01:00
2008-06-11 21:58:11 -04:00
2008-06-20 14:05:53 -06:00
2008-07-04 11:26:40 +02:00
2008-07-19 22:35:47 -07:00
2008-06-17 16:19:24 -07:00
2008-07-20 17:12:37 -07:00
2008-07-24 10:47:13 -07:00
2008-06-12 14:25:09 -07:00
2008-07-22 13:03:29 -07:00
2008-07-24 10:47:28 -07:00
2008-07-21 21:55:02 -07:00
2008-07-21 21:55:01 -07:00
2008-07-19 00:07:02 -07:00
2008-07-08 02:38:40 -07:00
2008-06-25 19:25:42 -04:00
2008-06-12 10:48:00 +02:00
2008-07-24 10:47:27 -07:00
2008-05-21 14:52:30 -07:00
2008-06-13 10:09:46 +02:00
2008-07-22 13:03:28 -07:00
2008-07-20 17:12:34 -07:00
2008-07-22 13:03:27 -07:00
2008-05-24 09:56:09 -07:00
2008-06-16 17:14:11 -07:00
2008-07-21 21:54:55 -07:00
2008-07-21 15:16:40 -07:00
2008-07-21 15:15:55 -07:00
2008-05-09 07:45:18 -07:00
2008-07-20 07:17:02 -03:00
2008-05-30 15:09:45 +10:00
2008-05-30 15:09:46 +10:00
2008-06-10 18:20:30 -04:00
2008-05-30 15:09:44 +10:00
2008-05-02 21:50:50 +10:00
2008-07-24 10:47:14 -07:00
2008-05-29 01:43:48 -07:00
2008-06-16 18:50:49 -07:00
2008-05-27 01:37:26 -04:00
2008-07-24 10:47:23 -07:00
2008-07-15 08:36:38 -07:00
2008-07-10 16:55:37 -07:00
ed8cae8ba0